Default relationships to ownership for Cosmos #25283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to reconfigure STETs as regular entity types Fixes #24803
smitpatel
reviewed
Jul 20, 2021
smitpatel
reviewed
Jul 20, 2021
smitpatel
reviewed
Jul 20, 2021
| && targetOwnership.PrincipalEntityType == entityType | ||
| && targetOwnership.PrincipalToDependent?.GetIdentifyingMemberInfo() != navigationMemberInfo) | ||
| { | ||
| Dependencies.Logger.NonOwnershipInverseNavigationWarning( |
There was a problem hiding this comment.
should this warning have different order for parameters? Right now it throws same as above block but represent inverse side
There was a problem hiding this comment.
Good eye, but the order is correct, InversePropertyAttribute_does_not_configure_non_ownership_navigation tests this. It's a bit confusing because the order of parameters in the Logger extension doesn't correspond to the order of parameters in the text itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to reconfigure STETs as regular entity types
Rerun
CosmosDiscriminatorConventionandBaseTypeDiscoveryConventionwhen ownership changesKeep
OwnedNavigationBuilder.DependentEntityTypeup-to-dayFixes #24803