Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using not readonly stuct with in modifier #24750

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Using not readonly stuct with in modifier #24750

merged 1 commit into from
Apr 27, 2021

Conversation

SergerGood
Copy link
Contributor

No description provided.

@ajcvickers ajcvickers assigned AndriySvyryd and roji and unassigned AndriySvyryd Apr 26, 2021
roji
roji approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd can you confirm this is right too?

AndriySvyryd
AndriySvyryd approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these were on hot path we could've switched to using ref

@roji
Copy link
Member

roji commented Apr 27, 2021

Yeah, though there's a struct size threshold below which it's better to pass by value and avoid the extra dereferencing etc., at least for Nullable<MemberIdentity> I wouldn't assume ref improves things.

Anyway... :)

@roji roji merged commit c375551 into dotnet:main Apr 27, 2021
@roji
Copy link
Member

roji commented Apr 27, 2021

Thanks @SergerGood!

@SergerGood SergerGood deleted the readonly-struct branch April 27, 2021 19:11
@ajcvickers ajcvickers mentioned this pull request May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@roji roji

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergerGood @roji @AndriySvyryd @ajcvickers