Update docs for building the code and contributing #24703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/efteam I would like to get this merged before the standup tomorrow. |
smitpatel
reviewed
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
roji
approved these changes
Apr 20, 2021
smitpatel
approved these changes
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
smitpatel
reviewed
Apr 20, 2021
ajcvickers
force-pushed
the
WhatToDo0420
branch
from
a37f4f4
to
ea1d7ea
Compare
ErikEJ
reviewed
Apr 21, 2021
|
|
||
| * The SQL Server tests require a local SQL Server installation. This can be: | ||
| * SQL Server LocalDb, usually obtained by installing the latest [Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) public preview with the "ASP.NET and web development" workload selected. | ||
| * SQL Server [Express or Developer Edition](https://www.microsoft.com/en-us/sql-server/sql-server-downloads). When not using LocalDb, make sure to set the environment variable `Test__SqlServer__DefaultConnection` to the connection string that EF Core tests should use. |
There was a problem hiding this comment.
Maybe provide an example of a .\SQLEXPRESS connection string
There was a problem hiding this comment.
@ErikEJ Good idea, but I'm going to merge this now. I'll loop back later, or you could send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.