Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Annotate NRTs #24388

Merged
1 commit merged into from
Mar 15, 2021
Merged

Design: Annotate NRTs #24388

1 commit merged into from
Mar 15, 2021

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Mar 12, 2021

Fixes #24403, part of #19007

See also #24387

@ghost
Copy link

ghost commented Mar 15, 2021

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3d6009b into dotnet:main Mar 15, 2021
@bricelam
Copy link
Contributor Author

Isn't the bot supposed to wait for the CI??

@bricelam bricelam deleted the nrtd branch March 15, 2021 20:51
@smitpatel
Copy link
Contributor

Looks like concurrency issue.

@roji
Copy link
Member

roji commented Mar 15, 2021

Sometimes bots just get really excited about nullability...

@smitpatel
Copy link
Contributor

may be AAD issue?

@roji
Copy link
Member

roji commented Mar 15, 2021

I dunno, nullability is really exciting...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffolding: Can't use global namespace
3 participants