[5.0.3] Set relationship snapshot correctly for skip navigations #23815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved by Tactics for 5.0.3; please wait for the branch to open before merging. |
AndriySvyryd
approved these changes
Jan 5, 2021
|
Quirk mode? |
|
@ajcvickers could you resolve the merge conflicts? |
ajcvickers
force-pushed
the
HolidaySnaps0104
branch
from
0b4e367
to
1d1b132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23787
Description
If skip navigations are detected to have values on a newly tracked entities, then these values need to be added to the relationship snapshot so that DetectChanges does not re-detect them. This is not happening for one path with store-generated keys.
Customer Impact
In most cases this has no impact, as DetectChanges catches up when it first runs. However, if changes are made to the graph before this happens, and if the entities have store-generated keys, then this can result in a change not being detected and hense an incorrect update to the database.
How found
Customer reported on 5.0.
Test coverage
This only happens when using store-generated keys, for which we were missing some many-to-many coverage. A previous PR added that coverage, and this PR adds additional validation of the relationship snapshot.
Regression?
No; new feature in 5.0.
Risk
Low. The relationship snapshot is now set correctly.