-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServer: Translate ArrayAccess/First over byte[] #23210
Conversation
src/EFCore.Sqlite.Core/Query/Internal/SqliteSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
2d0b59b
to
004a37d
Compare
Updated to just translate for SqlServer now. Sqlite we can continue the discussion in the issue itself. (leaving the issue open) |
004a37d
to
6c19b23
Compare
src/EFCore.SqlServer/Query/Internal/SqlServerByteArrayMethodTranslator.cs
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
maybe also add a query test - gears of war Squad has some |
These tests are running queries only. Do you think adding tests in gears of war will provide us additional coverage than what we have here? |
Just to see the generated sql, but I don't mind too either way |
Will add test. |
6c19b23
to
24903b0
Compare
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
Part of #16428