Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect projected ColumnExpression when using SqlQuery #34518

Open
roji opened this issue Aug 23, 2024 · 0 comments · May be fixed by #34519
Open

Incorrect projected ColumnExpression when using SqlQuery #34518

roji opened this issue Aug 23, 2024 · 0 comments · May be fixed by #34519
Assignees
@roji
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug type-enhancement
Milestone
10.0.0

Comments

@roji
Copy link
Member

roji commented Aug 23, 2024 •
edited
Loading

When translating SqlQueryRootExpression, the resulting SelectExpression's ColumnExpression (in _projectionMappings) has Type e.g. IQueryable<string> instead of string - this is an incorrect tree representation.

This triggered #33272, which was worked around by @cincuranet in #33580, but without addressing the actual root cause (which is an invalid tree). This surfaced again EFCore.PG where the workaround wasn't yet applied.
@roji roji self-assigned this Aug 23, 2024
@roji roji added this to the 10.0.0 milestone Aug 23, 2024
roji added a commit to roji/efcore that referenced this issue Aug 23, 2024
@roji
Fix CLR type of SqlQuery projected column
a52c191 
Fixes dotnet#34518
@roji roji linked a pull request Aug 23, 2024 that will close this issue
Draft
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 23, 2024
This was referenced Aug 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug type-enhancement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix CLR type of SqlQuery projected column roji/efcore
1 participant
@roji