Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically opt-out of SqlClient's retrying behavior for OpenAsync in EF's database existence check #33741

Open
roji opened this issue May 17, 2024 · 4 comments

Comments

@roji
Copy link
Member

roji commented May 17, 2024

SqlClient 5.1.2 added retrying behavior in the asynchronous OpenAsync; this already existed for sync Open, with a programmatic opt-out that EF uses when checking for a database's existence, but no such programmatic opt-out was introduced for the new async version.

The SqlClient plan is to revert the new async retry behavior for 5 (comment), and re-introduce it later in SqlClient 6 along with the opt-out. When that happens and when EF switches to SqlClient 6, we need to react and make use of that opt out.

@mu88

This comment has been minimized.

@roji

This comment has been minimized.

@mu88

This comment has been minimized.

@roji roji removed the regression label Aug 10, 2024
@roji
Copy link
Member Author

roji commented Aug 10, 2024

Note: the actual regression should be fixed by bumping our SqlClient dependency to the soon-to-be-released 5.1.6, which fully reverts the SqlClient change. This issue tracks implementing the opt-out when we upgrade 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants