Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging of unused index events from Info to Debug #24981

Closed
ajcvickers opened this issue May 26, 2021 · 0 comments · Fixed by #25928
Closed

Change logging of unused index events from Info to Debug #24981

ajcvickers opened this issue May 26, 2021 · 0 comments · Fixed by #25928
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

See dotnet/aspnetcore#32977 (comment)

Specifically:

  • The index named '{indexName}' on the entity type '{entityType}' specifies properties {indexProperties}, but none of these properties are mapped to a column in any table. This index will not be created in the database. (Will follow up on why this is at Info level. /cc @AndriySvyryd)
  • The unnamed index on the entity type '{entityType}' specifies properties {indexProperties}, but none of these properties are mapped to a column in any table. This index will not be created in the database. (Likewise)
@ajcvickers ajcvickers added this to the 6.0.0 milestone May 27, 2021
@ajcvickers ajcvickers self-assigned this May 27, 2021
ajcvickers added a commit that referenced this issue Sep 8, 2021
@ajcvickers
Change logging for validation of un-created index to Warning
9727807 
This was previously Info, which we had said should be Debug. But the way it is used in validation makes me think that Warning is more appropriate.

Fixes #24981
ajcvickers added a commit that referenced this issue Sep 8, 2021
@ajcvickers
Change logging level for non-created indexes from Info to Warn
3f66676 
Fixes #24981

We had decided to make these Debug, but after looking at how these are used I think it makes more sense to make them warnings.
@ajcvickers ajcvickers mentioned this issue Sep 8, 2021
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 8, 2021
ajcvickers added a commit that referenced this issue Sep 8, 2021
@ajcvickers
Change logging level for non-created indexes from Info to Warn (#25928)
0ad9edf 
Fixes #24981

We had decided to make these Debug, but after looking at how these are used I think it makes more sense to make them warnings.
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Sep 8, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Change logging level for non-created indexes from Info to Warn dotnet/efcore
1 participant
@ajcvickers