Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log provider version in addition to EF Core version #22906

Closed
lauxjpn opened this issue Oct 6, 2020 · 0 comments · Fixed by #25515
Closed

Log provider version in addition to EF Core version #22906

lauxjpn opened this issue Oct 6, 2020 · 0 comments · Fixed by #25515
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
6.0.0

Comments

@lauxjpn
Copy link
Contributor

lauxjpn commented Oct 6, 2020

Currently, only the EF Core version and the provider name is being logged, but not the provider version:

info: Microsoft.EntityFrameworkCore.Infrastructure[10403]
      Entity Framework Core 3.1.8 initialized 'Context' using provider 'Pomelo.EntityFrameworkCore.MySql' with options: ServerVersion 5.7.0 MySql SensitiveDataLoggingEnabled DetailedErrorsEnabled

It would be advantageous to also log the provider version, so it appears in posted log outputs and removes any ambiguity of what provider version is actually being used.

Moved from PomeloFoundation/Pomelo.EntityFrameworkCore.MySql#1184.
@ajcvickers ajcvickers added this to the Backlog milestone Oct 7, 2020
@ajcvickers ajcvickers self-assigned this Nov 4, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 4, 2020
ajcvickers added a commit that referenced this issue Aug 14, 2021
@ajcvickers
Log provider version in addition to EF Core version
741c26f 
Fixes #22906
@ajcvickers ajcvickers mentioned this issue Aug 14, 2021
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 14, 2021
ajcvickers added a commit that referenced this issue Aug 17, 2021
@ajcvickers
Log provider version in addition to EF Core version
bd7220d 
Fixes #22906
ajcvickers added a commit that referenced this issue Aug 17, 2021
@ajcvickers
Log provider version in addition to EF Core version (#25515)
531ea78 
* Log provider version in addition to EF Core version

Fixes #22906

* Fixing docs.
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 17, 2021
@ajcvickers ajcvickers mentioned this issue Sep 23, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Log provider version in addition to EF Core version dotnet/efcore
2 participants
@ajcvickers @lauxjpn