Migrations Bundles: Address API Review feedback

Part of #24743
dotnet · Aug 19, 2021 · 30abd9b · 30abd9b
1 parent 29f9e96
commit 30abd9b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/EFCore.Tools/tools/EntityFrameworkCore.PS2.psm1 b/src/EFCore.Tools/tools/EntityFrameworkCore.PS2.psm1
@@ -65,7 +65,7 @@ function Add-Migration(
 .PARAMETER SelfContained
     Also bundle the .NET runtime so it doesn't need to be installed on the machine.
 
-.PARAMETER Runtime
+.PARAMETER TargetRuntime
     The target runtime to bundle for.
 
 .PARAMETER Configuration
@@ -95,7 +95,7 @@ function Bundle-Migration(
     $Output,
     [switch] $Force,
     [switch] $SelfContained,
-    $Runtime,
+    $TargetRuntime,
     $Configuration,
     $Framework,
     $Context,

diff --git a/src/EFCore.Tools/tools/EntityFrameworkCore.psm1 b/src/EFCore.Tools/tools/EntityFrameworkCore.psm1
@@ -119,7 +119,7 @@ Register-TabExpansion Bundle-Migration @{
 .PARAMETER SelfContained
     Also bundle the .NET runtime so it doesn't need to be installed on the machine.
 
-.PARAMETER Runtime
+.PARAMETER TargetRuntime
     The target runtime to bundle for.
 
 .PARAMETER Configuration
@@ -152,7 +152,7 @@ function Bundle-Migration
         [string] $Output,
         [switch] $Force,
         [switch] $SelfContained,
-        [string] $Runtime,
+        [string] $TargetRuntime,
         [string] $Configuration,
         [string] $Framework,
         [string] $Context,
@@ -185,14 +185,14 @@ function Bundle-Migration
         $params += '--self-contained'
     }
 
-    if ($Runtime)
+    if ($TargetRuntime)
     {
-        $params += '--bundle-runtime', $Runtime
+        $params += '--target-runtime', $TargetRuntime
     }
 
     if ($Configuration)
     {
-        $params += '--bundle-configuration', $Configuration
+        $params += '--target-configuration', $Configuration
     }
 
     $params += GetParams $Context

diff --git a/src/ef/Commands/MigrationsBundleCommand.Configure.cs b/src/ef/Commands/MigrationsBundleCommand.Configure.cs
@@ -21,8 +21,8 @@ public override void Configure(CommandLineApplication command)
             _output = command.Option("-o|--output <FILE>", Resources.MigrationsBundleOutputDescription);
             _force = command.Option("-f|--force", Resources.DbContextScaffoldForceDescription);
             _selfContained = command.Option("--self-contained", Resources.SelfContainedDescription);
-            _runtime = command.Option("-r|--bundle-runtime <RUNTIME_IDENTIFIER>", Resources.MigrationsBundleRuntimeDescription);
-            _configuration = command.Option("--bundle-configuration <CONFIGURATION>", Resources.MigrationsBundleConfigurationDescription);
+            _runtime = command.Option("-r|--target-runtime <RUNTIME_IDENTIFIER>", Resources.MigrationsBundleRuntimeDescription);
+            _configuration = command.Option("--target-configuration <CONFIGURATION>", Resources.MigrationsBundleConfigurationDescription);
 
             base.Configure(command);
         }

diff --git a/src/ef/Commands/MigrationsBundleCommand.cs b/src/ef/Commands/MigrationsBundleCommand.cs
@@ -98,7 +98,7 @@ protected override int Execute(string[] args)
 
                 var outputPath = _output!.HasValue()
                     ? _output!.Value()!
-                    : "bundle" + exe;
+                    : "efbundle" + exe;
                 var bundleName = Path.GetFileNameWithoutExtension(outputPath);
 
                 File.WriteAllText(