Increase default context pool size from 128 to 1024

Closes #24849
dotnet · May 10, 2021 · 1fb5047 · 1fb5047
1 parent cc09604
commit 1fb5047
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs b/src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
@@ -145,7 +145,7 @@ public static IServiceCollection AddDbContext<TContextService, TContextImplement
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddDbContextPool<TContext>(
             this IServiceCollection serviceCollection,
@@ -187,7 +187,7 @@ public static IServiceCollection AddDbContextPool<TContext>(
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddDbContextPool<TContextService, TContextImplementation>(
             this IServiceCollection serviceCollection,
@@ -241,7 +241,7 @@ public static IServiceCollection AddDbContextPool<TContextService, TContextImple
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddDbContextPool<TContext>(
             this IServiceCollection serviceCollection,
@@ -292,7 +292,7 @@ public static IServiceCollection AddDbContextPool<TContext>(
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddDbContextPool<TContextService, TContextImplementation>(
             this IServiceCollection serviceCollection,
@@ -814,7 +814,7 @@ public static IServiceCollection AddDbContextFactory<TContext, TFactory>(
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddPooledDbContextFactory<TContext>(
             this IServiceCollection serviceCollection,
@@ -858,7 +858,7 @@ public static IServiceCollection AddPooledDbContextFactory<TContext>(
         ///         will not be called.
         ///     </para>
         /// </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         /// <returns> The same service collection so that multiple calls can be chained. </returns>
         public static IServiceCollection AddPooledDbContextFactory<TContext>(
             this IServiceCollection serviceCollection,

diff --git a/src/EFCore/Infrastructure/PooledDbContextFactory.cs b/src/EFCore/Infrastructure/PooledDbContextFactory.cs
@@ -34,7 +34,7 @@ public PooledDbContextFactory(IDbContextPool<TContext> pool)
         ///     Initializes a new instance of the <see cref="PooledDbContextFactory{TContext}" /> class.
         /// </summary>
         /// <param name="options"> The options to use for contexts produced by this factory. </param>
-        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 128. </param>
+        /// <param name="poolSize"> Sets the maximum number of instances retained by the pool. Defaults to 1024. </param>
         public PooledDbContextFactory(DbContextOptions<TContext> options, int poolSize = DbContextPool<DbContext>.DefaultPoolSize)
         {
             var optionsBuilder = new DbContextOptionsBuilder<TContext>(options);

diff --git a/src/EFCore/Internal/DbContextPool.cs b/src/EFCore/Internal/DbContextPool.cs
@@ -29,7 +29,7 @@ public class DbContextPool<TContext> : IDbContextPool<TContext>, IDisposable, IA
         ///     any release. You should only use it directly in your code with extreme caution and knowing that
         ///     doing so can result in application failures when updating to a new Entity Framework Core release.
         /// </summary>
-        public const int DefaultPoolSize = 128;
+        public const int DefaultPoolSize = 1024;
 
         private readonly ConcurrentQueue<IDbContextPoolable> _pool = new();
 

diff --git a/test/EFCore.SqlServer.FunctionalTests/DbContextPoolingTest.cs b/test/EFCore.SqlServer.FunctionalTests/DbContextPoolingTest.cs
@@ -261,7 +261,7 @@ public void Validate_pool_size_default()
             using var scope = serviceProvider.CreateScope();
 
             Assert.Equal(
-                128,
+                1024,
                 scope.ServiceProvider
                     .GetRequiredService<PooledContext>()
                     .GetService<IDbContextOptions>()
@@ -276,7 +276,7 @@ public void Validate_pool_size_with_service_interface_default()
             using var scope = serviceProvider.CreateScope();
 
             Assert.Equal(
-                128,
+                1024,
                 ((DbContext)scope.ServiceProvider
                     .GetRequiredService<IPooledContext>())
                 .GetService<IDbContextOptions>()
@@ -291,7 +291,7 @@ public void Validate_pool_size_with_factory_default()
             using var context = serviceProvider.GetRequiredService<IDbContextFactory<PooledContext>>().CreateDbContext();
 
             Assert.Equal(
-                128,
+                1024,
                 context.GetService<IDbContextOptions>()
                     .FindExtension<CoreOptionsExtension>().MaxPoolSize);
         }