Add msquic to OpenSUSE #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2022
wfurt
reviewed
Sep 9, 2022
| ENV LANG=en_US.utf8 | ||
|
|
||
| RUN wget https://github.com/microsoft/msquic/releases/download/v2.1.1/libmsquic-2.1.1-1.x86_64.rpm && \ | ||
| rpm -i libmsquic-2.1.1-1.x86_64.rpm && \ |
Member
There was a problem hiding this comment.
This seems to bypass signature checking.
rpm -i libmsquic-2.1.1-1.x86_64.rpm
warning: libmsquic-2.1.1-1.x86_64.rpm: Header V4 RSA/SHA256 Signature, key ID be1229cf: NOKEY
zypper can install packages directly via http without wget.
zypper install -y https://github.com/microsoft/msquic/releases/download/v2.1.1/libmsquic-2.1.1-1.x86_64.rpm
it fails on signature verification ... that is probably correct. My recommendation would be to add signing key
Member
Author
There was a problem hiding this comment.
I will probably need some hint about the signing key, I have never done that sort of thing before
Member
There was a problem hiding this comment.
bde607ad2ca8:/ # rpm --import https://packages.microsoft.com/keys/microsoft.asc
bde607ad2ca8:/ # zypper install -y https://github.com/microsoft/msquic/releases/download/v2.1.1/libmsquic-2.1.1-1.x86_64.rpm
Loading repository data...
Warning: Repository 'Main Update Repository' appears to be outdated. Consider using a different mirror or server.
Warning: Repository 'Update Repository (Non-Oss)' appears to be outdated. Consider using a different mirror or server.
Reading installed packages...
Resolving package dependencies...
The following NEW package is going to be installed:
libmsquic
1 new package to install.
Overall download size: 6.1 MiB. Already cached: 0 B. After the operation, additional 22.0 MiB will be used.
Continue? [y/n/v/...? shows all options] (y): y
Retrieving package libmsquic-2.1.1-1.x86_64 (1/1), 6.1 MiB ( 22.0 MiB unpacked)
Checking for file conflicts: ...................................................................................................................................................................................................................[done]
(1/1) Installing: libmsquic-2.1.1-1.x86_64 .....................................................................................................................................................................................................[done]
I would add same download + verify checksum + import logic we have elsewhere.
This may be paranoid but prevents cases when somebody sneaks evil bits on the server.
rzikm
force-pushed
the
opensuse-msquic
branch
from
8e20c33 to
548b3d2
Compare
mthalman
reviewed
Sep 12, 2022
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs MsQuic 2.1.1 from official rpm from github (I did not find a way to add packages.microsoft.com feed to zypper). Tests run, except that IPv6 is apparently disabled on the image. That is going to be mitigated by dotnet/runtime#75341.