Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Sep 19, 2023

Changes based on code review on dotnet/runtime#92220

@rzikm rzikm requested a review from a team as a code owner September 19, 2023 08:12
@ghost ghost assigned rzikm Sep 19, 2023
@ghost ghost added the area-System.Net label Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Changes based on code review on dotnet/runtime#92220

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 91730c9:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 91730c96fcd22758091f5c89c0317e47d6623560 in branch 88569-mediatypenames of repository https://github.com/rzikm/dotnet-api-docs into branch main (commit 651a244db8a97e89732a1dd98e7bbe0167c926bf). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 28c05e1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Mime/MediaTypeNames+Application.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Multipart.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Text.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@rzikm
Copy link
Member Author

rzikm commented Sep 19, 2023

The wording has been approved by gewarren on dotnet/runtime#92220

@rzikm rzikm merged commit a4520db into dotnet:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants