Skip to content

Fixed typo error in NumberFormatInfo.NegativeSign Property example #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

prasadtelkikar
Copy link
Contributor

Summary

In the example, an instance of CultureInfo is defined with the variable name ci. While converting a number into a string, culture variable is used instead of the variable name ci.

This PR contains, use of ci variable. This will resolve compile-time error.

Fixes #7552 Typo error in NumberFormatInfo.NegativeSign Property example

@prasadtelkikar prasadtelkikar requested a review from a team as a code owner January 5, 2022 18:11
@dnfadmin
Copy link

dnfadmin commented Jan 5, 2022

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Jan 5, 2022

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

In the example, an instance of CultureInfo is defined with the variable name ci. While converting a number into a string, culture variable is used instead of the variable name ci.

This PR contains, use of ci variable. This will resolve compile-time error.

Fixes #7552 Typo error in NumberFormatInfo.NegativeSign Property example

Author: prasadtelkikar
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@gewarren
Copy link
Contributor

gewarren commented Jan 5, 2022

Thank you @prasadtelkikar. Could you add a .csproj and .vbproj file to the corresponding folders too? For .csproj, it's as simple as this: https://github.com/dotnet/dotnet-api-docs/blob/main/samples/snippets/csharp/api/system.io/path/combine/misc.csproj. That way the sample code can be compiled during PR checks.

@prasadtelkikar
Copy link
Contributor Author

Hi @tarekgh ,

I raised PR against issue #7553, Kindly review it and let me know if there is anything I missed.
This is my First PR to dotnet-api-docs repository.

Happy coding.... 😇

Thanks,
Prasad

@opbld30
Copy link

opbld30 commented Jan 5, 2022

Docs Build status updates of commit 478450f:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR_System/system.globalization.numberformatinfo.negativesign/cs/negativesign1.cs ✅Succeeded View
samples/snippets/visualbasic/VS_Snippets_CLR_System/system.globalization.numberformatinfo.negativesign/vb/negativesign1.vb ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @prasadtelkikar for fixing that.

@tarekgh tarekgh merged commit 4ea5835 into dotnet:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo error in NumberFormatInfo.NegativeSign Property example
5 participants