Skip to content

Provide valid C# example and remove C++/CLI function definition. #4782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

AaronRobinsonMSFT
Copy link
Member

Fixes #1120

/cc @dotnet/docs @elinor-fung @jkoritzinsky

@opbld31
Copy link

opbld31 commented Sep 2, 2020

Docs Build status updates of commit 137accf:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR_System/system.runtime.interopservices.icustommarshaler/cs/source.cs ✅Succeeded View
xml/System.Runtime.InteropServices/ICustomMarshaler.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@AaronRobinsonMSFT
Copy link
Member Author

@gewarren PTAL. Thanks!

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tweaked the intro to the example.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31
Copy link

opbld31 commented Sep 3, 2020

Docs Build status updates of commit 1370afa:

🕙 Pending: waiting for processors (14 builds ahead of you)

⚠️ Docs Build is busy, currently there are 14 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld33
Copy link

opbld33 commented Sep 3, 2020

Docs Build status updates of commit 1370afa:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR_System/system.runtime.interopservices.icustommarshaler/cs/source.cs ✅Succeeded View
xml/System.Runtime.InteropServices/ICustomMarshaler.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 82f3f82 into dotnet:master Sep 3, 2020
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the apidocs1120 branch September 3, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Implementing the GetInstance Method" on ICustomMarshaler needs language-specific example
5 participants