Skip to content

Fix casing of bufferoffset to bufferOffset #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

deisterhold
Copy link

Summary

Make the letter o uppercase.

Fixes #Issue_Number (if available)

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 6, 2020
@mairaw
Copy link
Contributor

mairaw commented Jul 8, 2020

Thanks @deisterhold. I agree that would be the appropriate name but on docs we need to show what's in the source code:
https://source.dot.net/#System.Data.Common/System/Data/IDataRecord.cs,22

For this reason, I'm closing this PR. You could file an issue at https://github.com/dotnet/runtime/issues and see if they would take this change. And then docs would automatically get the update.

@mairaw mairaw closed this Jul 8, 2020
@deisterhold
Copy link
Author

@mairaw Ok, thanks. I guess I was looking at the implementation and assumed they were the same.

@deisterhold deisterhold deleted the patch-1 branch July 8, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants