Space characters are encoded as '+' #3124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing description implies that the specified character classes are the only exceptions to hexadecimal encoding. I'm trying to match Javascript 'encodeURIComponent' behavior, and expected WebUtility.UrlEncode to provide this. However, as spaces are a further exception, this method produces results that are functionally identical to that produced by HttpUtility.UrlEncode. Might also be useful to mention Uri.EscapeDataString and AntiXss.UrlEncode as well here, as these are now preferred options when looking to encode URIs in a transparent, reversible manner.
mairaw
added
the
✨ 1st-time dotnet-api-docs contributor!
|
@davidsh can you please review this change? |
davidsh
reviewed
Sep 5, 2019
mairaw
requested changes
Sep 5, 2019
There was a problem hiding this comment.
Thanks @davidsh for your help! Applying your comment as a suggestion so @RichTeaTime can easily apply the fix.
mairaw
approved these changes
Sep 6, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing description implies that the specified character classes are the only exceptions to hexadecimal encoding.
I'm trying to match Javascript 'encodeURIComponent' behavior, and expected WebUtility.UrlEncode to provide this.
However, as spaces are a further exception, this method produces results that are functionally identical to that produced by HttpUtility.UrlEncode.
Might also be useful to mention Uri.EscapeDataString and AntiXss.UrlEncode as well here, as these are now preferred options when looking to encode URIs in a transparent, reversible manner.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)