Skip to content

Refer <gcAllowVeryLargeObjects> element #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Conversation

DiegoQueiroz
Copy link
Contributor

The current version miss to tell what element should be changed to change the array limit

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

The current version miss to tell what element should be changed to change the array limit
@BillWagner
Copy link
Member

@safern Can you review this change? It LGTM, but I'd like you to make sure it's correct.

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DiegoQueiroz, for contributing to the dotnet/dotnet-api-docs repo and adding this detail. I agree with @mikedn that the paragraph should make it clear that it applies to .NET Framework only. It also would be preferable for the reference to <gcAllowVeryLargeObjects> to be a link.

@rpetrusha rpetrusha added the ✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository label Dec 7, 2018
@Thieum
Copy link

Thieum commented Dec 10, 2018

It seems to impact other containers as well, as seen in #1282

@mairaw
Copy link
Contributor

mairaw commented Dec 13, 2018

Yes, @Thieum we found out this is a migration issue and we're tracking the fix with issue #1364. @DiegoQueiroz I left the feedback in the form of a suggestion so you can just commit the fix. Thanks!

Co-Authored-By: DiegoQueiroz <queiroz.diego@gmail.com>
@DiegoQueiroz
Copy link
Contributor Author

I'm not good with PR, but is anything missing? It seems @rpetrusha request change was not addressed, but it actually is.

@rpetrusha
Copy link

No, nothing is missing, @DiegoQueiroz. Your changes look good, so I'll merge your PR now. The changes should appear on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit 2c7fc16 into dotnet:master Dec 13, 2018
@DiegoQueiroz DiegoQueiroz deleted the patch-1 branch December 13, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time dotnet-api-docs contributor! Indicates PRs from new contributors to the dotnet-api-docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants