-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Refer <gcAllowVeryLargeObjects> element #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current version miss to tell what element should be changed to change the array limit
@safern Can you review this change? It LGTM, but I'd like you to make sure it's correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @DiegoQueiroz, for contributing to the dotnet/dotnet-api-docs repo and adding this detail. I agree with @mikedn that the paragraph should make it clear that it applies to .NET Framework only. It also would be preferable for the reference to <gcAllowVeryLargeObjects> to be a link.
It seems to impact other containers as well, as seen in #1282 |
Yes, @Thieum we found out this is a migration issue and we're tracking the fix with issue #1364. @DiegoQueiroz I left the feedback in the form of a suggestion so you can just commit the fix. Thanks! |
Co-Authored-By: DiegoQueiroz <queiroz.diego@gmail.com>
I'm not good with PR, but is anything missing? It seems @rpetrusha request change was not addressed, but it actually is. |
No, nothing is missing, @DiegoQueiroz. Your changes look good, so I'll merge your PR now. The changes should appear on docs.microsoft.com in the next day or two. |
The current version miss to tell what element should be changed to change the array limit
Summary
Describe your changes here.
Fixes #Issue_Number (if available)