Updated Documentation for RequestLengthDiskThreshold #12084
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes dotnet#12083 As noted in the issue, the value that is specified here is a value in KB, however, the documentation contained mixed references to both kilobytes and bytes. I updated this to reflect properly kilobytes in all locations.
dotnet-policy-service
bot
added
the
community-contribution
2 tasks
Copilot finished reviewing on behalf of
mitchelsellers
November 28, 2025 15:15
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes documentation inconsistencies for the RequestLengthDiskThreshold property by standardizing all references to use "kilobytes" instead of the previously mixed "bytes" and "kilobytes" terminology.
Key changes:
- Updated XML documentation to consistently reference kilobytes as the unit of measurement
- Corrected code comments in both C# and Visual Basic snippet files to reflect kilobytes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| xml/System.Web.Configuration/HttpRuntimeSection.xml | Updated the <value> and <remarks> sections to consistently reference kilobytes instead of bytes |
| snippets/visualbasic/VS_Snippets_WebNet/System.Web.Configuration.HttpRuntimeSection/VB/httpruntimesection.vb | Corrected comment to indicate the value is in kilobytes |
| snippets/csharp/VS_Snippets_WebNet/System.Web.Configuration.HttpRuntimeSection/CS/httpruntimesection.cs | Corrected comment to indicate the value is in kilobytes |
|
This is great @mitchelsellers - thank you for submitting this PR. This has bit us for years! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As noted in the issue, the value that is specified here is a value in KB, however, the documentation contained mixed references to both kilobytes and bytes.
I updated this to reflect kilobytes properly in all locations, including the snippets and actual documentation
Fixes #12083