Skip to content

Port Microsoft.Extensions new docs #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 13, 2024
Merged

Port Microsoft.Extensions new docs #10208

merged 18 commits into from
Aug 13, 2024

Conversation

carlossanlop
Copy link
Contributor

Lots of file changes but few changes within each file.

@carlossanlop carlossanlop requested a review from gewarren August 6, 2024 22:29
@carlossanlop carlossanlop self-assigned this Aug 6, 2024
@carlossanlop carlossanlop requested review from a team as code owners August 6, 2024 22:29
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-caching

@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@carlossanlop
Copy link
Contributor Author

Tagging area owners for a code review:

  • @dotnet/area-extensions-caching
  • @dotnet/area-extensions-configuration
  • @dotnet/area-extensions-dependencyinjection
  • @dotnet/area-extensions-filesystem
  • @dotnet/area-extensions-hosting
  • @dotnet/area-extensions-logging

@carlossanlop carlossanlop requested review from a team August 7, 2024 19:18
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
jozkee
jozkee reviewed Aug 7, 2024
View reviewed changes
@carlossanlop @jozkee
Apply suggestions from code review
981eb1f 
Co-authored-by: David Cantú <dacantu@microsoft.com>
@carlossanlop
Copy link
Contributor Author

The NFloat warning is unrelated to this PR, it's being fixed in #10211 (comment)

@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@carlossanlop
Copy link
Contributor Author

Ping, can I please get a review? @gewarren, @dotnet/area-extensions-caching @dotnet/area-extensions-configuration @dotnet/area-extensions-dependencyinjection @dotnet/area-extensions-filesystem @dotnet/area-extensions-hosting @dotnet/area-extensions-logging

@carlossanlop carlossanlop enabled auto-merge (squash) August 12, 2024 18:50
gewarren
gewarren approved these changes Aug 13, 2024
View reviewed changes
@carlossanlop @gewarren
Apply suggestions from code review
7d39eff 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlop @gewarren
Apply suggestions from code review
4d2ad5e 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 7d39eff:

💡 Validation status: suggestions

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml 💡Suggestion View Details
xml/Microsoft.Extensions.Caching.Distributed/IBufferDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCacheEntryFlags.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCacheEntryOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/IHybridCacheSerializer`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/IHybridCacheSerializerFactory.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceDescriptor.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Physical/PhysicalDirectoryInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting.WindowsServices/WindowsServiceLifetime.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/Host.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/SystemdHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingScopeHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Abstractions/NullLogger.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Abstractions/NullLogger`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptionsChangeTokenSource`2.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/ConsoleLoggerSettings.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.EventSource/LoggingEventSource.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 4d2ad5e:

💡 Validation status: suggestions

File Status Preview URL Details
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml 💡Suggestion View Details
xml/Microsoft.Extensions.Caching.Distributed/IBufferDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCacheEntryFlags.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/HybridCacheEntryOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/IHybridCacheSerializer`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Hybrid/IHybridCacheSerializerFactory.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceDescriptor.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders.Physical/PhysicalDirectoryInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting.WindowsServices/WindowsServiceLifetime.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/Host.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/SystemdHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Http.Logging/LoggingScopeHttpMessageHandler.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Abstractions/NullLogger.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Abstractions/NullLogger`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptionsChangeTokenSource`2.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/ConsoleLoggerSettings.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.EventSource/LoggingEventSource.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop carlossanlop merged commit ccf3f88 into dotnet:main Aug 13, 2024
3 checks passed
@carlossanlop carlossanlop deleted the PortMicrosoftExtensions branch August 13, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozkee jozkee jozkee left review comments

@gewarren gewarren gewarren approved these changes

Assignees

@carlossanlop carlossanlop

Labels
area-Extensions-Caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @jozkee @gewarren