markdig changes - core and standard folders #6766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
rpetrusha
approved these changes
Aug 2, 2018
|
|
||
| ```csharp | ||
| public class CustomEndpoint : ServiceEndpoint | ||
| { |
There was a problem hiding this comment.
this is really a nit (not to mention unrelated to the PR), but the indentation here is troublesome.
| Friend Sub New(prefix As String, localname As String, nsURI As String, doc As XmlDocument) | ||
| MyBase.New(prefix, localname, nsURI, doc) | ||
| CType(doc, LineInfoDocument).IncrementElementCount() | ||
| End Sub 'New |
There was a problem hiding this comment.
Note the highlighted characters here. It usually indicates some unusual (non-printing?) character in the file. Here, each of those comments can be removed -- they were auto-generated by the C#-to-VB conversion tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6581
Hide whitespace changes for easier diff