Skip to content

fix bad code migration #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2017
Merged

fix bad code migration #3389

merged 2 commits into from
Oct 13, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 12, 2017

While working on PR #3382, I've noticed these strange characters in the topic and thought they looked wrong.

Here's the old version of the same topic:
https://msdn.microsoft.com/en-us/library/4571ccfe-8a60-4f06-9b37-7ac0b1c2d10f(vs.100)

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. There are two nits, completely unrelated to your PR, that you can feel free to ignore. Incidentally, it looks as if the migration to CAPS replaced the code point with its character.

@@ -34,13 +30,13 @@ This topic introduces issues that you should be aware of when writing
A character reference gives the number of the particular [!INCLUDE[TLA#tla_unicode](../../../../includes/tlasharptla-unicode-md.md)] character it represents, in either decimal or hexadecimal. The following example shows a decimal character reference.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits unrelated to your PR:
nit #1: rather than "number", a more precise "UTF16 code unit"
nit #2: no one is likely to know what U+03E8 is, so I'm wondering if it's helpful to mention it. It's COPTIC CAPITAL LETTER HORI, or 'Ϩ'.

@mairaw
Copy link
Contributor Author

mairaw commented Oct 13, 2017

@rpetrusha I've addressed your feedback. Please let me know if I got that right.

@rpetrusha
Copy link
Contributor

Yes, you did get it right, @mairaw. Thanks for making the additional improvements.

@mairaw mairaw merged commit 4ea2d06 into dotnet:master Oct 13, 2017
@mairaw mairaw deleted the weird-characters branch October 13, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants