-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Cleanup trimming options and document TrimMode=full,partial #30279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Right now I'm fighting some infra fires and am not sure when I'll be able to rewrite the article to use the "trimmable" terminology. Do we want to take this as-is and have that be a second PR? |
sbomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more minor comments but LGTM. Thank you!
|
We'll also need to update the options summary here: https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#trim-related-properties. |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
@gewarren Anything else? I presume we want to merge this ASAP so that people who see the breaking change notice have more details about workarounds. |
We'll also need to update the options summary here: https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#trim-related-properties. But I can do that in a separate PR if you like. |
|
Done, thanks |
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Internal preview link.