Revised class library getting started topics for .NET Core 2.0 #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BillWagner @rpetrusha I have rebased this branch to resolve the merge conflicts |
BillWagner
approved these changes
Aug 8, 2017
There was a problem hiding this comment.
Overall, this looks great @rpetrusha
I found one error where a VB file is referred to as a CS file. After that, it's time to 
docs/core/tutorials/index.md
Outdated
| @@ -40,7 +41,7 @@ The following tutorials are available for learning about .NET Core. | |||
|
|
|||
| - [Getting started with .NET Core on Windows/Linux/macOS using the .NET Core CLI tools](using-with-xplat-cli.md) | |||
| - [Organizing and testing projects with the .NET Core CLI tools](testing-with-cli.md) | |||
| - [Getting started with F#](../../fsharp/tutorials/getting-started/getting-started-command-line.md) | |||
| - [Getting started with F#](../../fsharp/tutorials/getting-started/get-started-command-line.md) | |||
There was a problem hiding this comment.
Should the TOC node also change to 'Get started with F#'?
There was a problem hiding this comment.
@BillWagner, yes, I'll do this in a separate PR.
| > [!NOTE] | ||
| > In addition to a Unit Test project, you can also use Visual Studio to create an xUnit test project for .NET Core. | ||
|
|
||
| 1. Visual Studio creates the project and opens the *UnitTest1.cs* file in the code window. |
There was a problem hiding this comment.
In the VB section, shouldn't this be TestLibrary.vb?
|
@mairaw, thanks for rebasing the branch for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised class library getting started topics for .NET Core 2.0
Also adds a VB class library tutorial, and uses tabs for the test tutorial. (The consuming a class library tutorial is will come shortly.)
I'll do TOC modifications and redirects in a separate PR.
Suggested Reviewers
@mairaw @BillWagner