Remove duplicate uids #2254
Merged
Remove duplicate uids #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Round 2
|
It's not showing here but PR has failed. I'll try again. |
mairaw
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2243
@mairaw I ran each script once on the repo to achieve this effect.
Script 1: https://gist.github.com/GuardRex/29bc96a0f5cd0f3e7b2c9cc4036ab4f5
Script 2: https://gist.github.com/GuardRex/a7e27e558e943094347573d0c47da699
Script 1 orders the entries (descending by length) so that when
Distinct(with anIEqualityComparerto filter on theuid) keeps the first one, it's keeping the longer one, which is the one with thems.authorandmanager. To preserve the original order, it doesn't write out the unique entries at that point. It uses the unique entries to filter and write out the original list; therefore, the original order is preserved.Script 2 simply uses
Distinctto obtain the unique entries. The result is written directly back to the file, because the order wasn't changed.