Fixes to the CI document #2161
Merged
Fixes to the CI document #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use install script in build matrix * add travis docs, and template * travis, add custom install using install script
* use install script in build matrix * add travis docs, and template * travis, add custom install using install script
|
Stand-by ... I'll see if I can get that failure fixed. |
Update
|
@mairaw @rpetrusha Nice ... a little extra polish on this last pass. It's ready for 👀 now. |
BillWagner
approved these changes
May 30, 2017
There was a problem hiding this comment.
@guardrex This looks great.
I had one wording suggestion. See what you think. Then, 
docs/core/tools/using-ci-with-cli.md
Outdated
| # Run the build process now. Implement your build script here. | ||
| ``` | ||
|
|
||
| You provide the implementation for your build process at the end of the script. When run and after the tooling is acquired, the script executes your build process. For UNIX machines, the following bash script performs the actions described in the PowerShell script in a similar manner: |
There was a problem hiding this comment.
nit: "When run and after tooling is acquired" seems awkward. Maybe say "The script acquires the tools and then executes your build process."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to the CI document.
Replaces #1556
Fixes #1454