Update porting overview and dependencies section #14621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build report has a broken link introduced because of the removal of one of the headings. I'll look at the overall changes now. |
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
This should make some of that better, but since we don't really have any actual tooling to help with porting (at least not anything supported) beyond migrating to PackageReference there isn't much to do. Seems like a decent number of those comments are from folks who want that. |
|
@mairaw this one is ready from my perspective |
|
Is this ready for a new review @cartermp? |
|
Yep!
…On Wed, Oct 2, 2019, at 21:36, Maira Wenzel wrote:
Is this ready for a new review @cartermp <https://github.com/cartermp>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#14621?email_source=notifications&email_token=ABQEJTXMYAAADTTLXQELGCDQMVZEBA5CNFSM4IZZ6NZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAG6QEA#issuecomment-537782288>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQEJTRYKJLMYSAYWF5OGYDQMVZEBANCNFSM4IZZ6NZA>.
|
|
@cartermp I gave this a quick read this morning. Other than Maira's one question and the merge conflicts, I think it's ready. |
mairaw
approved these changes
Oct 22, 2019
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with some adjusted guidance for the 3.0 release