Skip to content

Updating CLI golden path documents for preview 3 #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 17, 2016
Merged

Conversation

bleroy
Copy link
Contributor

@bleroy bleroy commented Nov 16, 2016

Title

Updating CLI golden path documents for preview 3.

Summary

Two new documents are added that are updated versions of /docs/core/tutorials/using-with-xplat-cli.md. The tutorial is also split in two to isolate the core of the tutorial from more optional and advanced parts.

Suggested Reviewers

@mairaw @blackdwarf @BillWagner @kendrahavens @cartermp

@saldana
Copy link

saldana commented Nov 16, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/core/tutorials/using-with-xplat-cli-msbuild.md ⚠️Warning View Details
docs/core/tutorials/using-with-xplat-cli-msbuild-folders.md ✅Succeeded View Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded View Details

docs/core/tutorials/using-with-xplat-cli-msbuild.md

  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/deploying/index.md).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@saldana
Copy link

saldana commented Nov 16, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/core/tutorials/using-with-xplat-cli-msbuild.md ⚠️Warning View Details
docs/core/tutorials/using-with-xplat-cli-msbuild-folders.md ✅Succeeded View Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded View Details

docs/core/tutorials/using-with-xplat-cli-msbuild.md

  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/deploying/index.md).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mairaw
Copy link
Contributor

mairaw commented Nov 16, 2016

I haven't had a chance to read these yet, but should this go to the cli-preview3 folder we're creating in PR #1233? The Core guide will stay with the Preview 2 content.

@saldana
Copy link

saldana commented Nov 16, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild-folders.md ⚠️Warning View Details
docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild.md ⚠️Warning View Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded View Details

docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild-folders.md

  • Line 300: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-test.md).

docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild.md

  • Line 19: [Warning] Invalid file link:(~/docs/cli-preview3/sdk.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/deploying/index.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-run.md).
  • Line 313: [Warning] Invalid file link:(~/docs/cli-preview3/tutorials/cli-console-app-tutorial-advanced.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-build.md).
  • Line 112: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-restore.md).
  • Line 39: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-new.md).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@saldana
Copy link

saldana commented Nov 17, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/cli-preview3/tutorials/using-on-windows-vs-2017.md ⚠️Warning View Details
docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild-folders.md ⚠️Warning View Details
docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild.md ⚠️Warning View Details
docs/cli-preview3/tutorials/using-on-windows-vs-2017-full-solution.md ✅Succeeded View Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded View Details

docs/cli-preview3/tutorials/using-on-windows-vs-2017.md

  • Line 45: [Warning] Invalid file link:(~/docs/cli-preview3/tutorials/using-on-windows-vs-2017-full-solution).

docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild-folders.md

  • Line 300: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-test.md).

docs/cli-preview3/tutorials/using-with-xplat-cli-msbuild.md

  • Line 19: [Warning] Invalid file link:(~/docs/cli-preview3/sdk.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/deploying/index.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-run.md).
  • Line 313: [Warning] Invalid file link:(~/docs/cli-preview3/tutorials/cli-console-app-tutorial-advanced.md).
  • Line 118: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-build.md).
  • Line 112: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-restore.md).
  • Line 39: [Warning] Invalid file link:(~/docs/cli-preview3/tools/dotnet-new.md).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@bleroy bleroy merged commit a6f4412 into master Nov 17, 2016
@bleroy bleroy deleted the core-golden-path branch November 17, 2016 01:36
@saldana
Copy link

saldana commented Nov 17, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/core/preview3/tutorials/using-on-windows-vs-2017.md ⚠️Warning View Details
docs/core/preview3/tutorials/using-on-windows-vs-2017-full-solution.md ✅Succeeded View Details
docs/core/preview3/tutorials/using-with-xplat-cli-msbuild-folders.md ✅Succeeded View Details
docs/core/preview3/tutorials/using-with-xplat-cli-msbuild.md ✅Succeeded View Details
docs/core/preview3/windows-prerequisites.md ✅Succeeded View Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded View Details

docs/core/preview3/tutorials/using-on-windows-vs-2017.md

  • Line 45: [Warning] Invalid file link:(~/docs/core/preview3/tutorials/using-on-windows-vs-2017-full-solution).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@saldana
Copy link

saldana commented Nov 17, 2016

❌ Validation status: errors

File Status Preview URL Details
docs/core/preview3/tutorials/index.md ✅Succeeded Details
docs/core/preview3/tutorials/media/console-app-solution.png ✅Succeeded Details
docs/core/preview3/tutorials/media/new-project-console-app.png ✅Succeeded Details
docs/core/preview3/tutorials/using-on-windows-vs-2017-full-solution.md ✅Succeeded Details
docs/core/preview3/tutorials/using-on-windows-vs-2017.md ✅Succeeded Details
docs/core/preview3/tutorials/using-with-xplat-cli-msbuild-folders.md ✅Succeeded Details
docs/core/preview3/tutorials/using-with-xplat-cli-msbuild.md ✅Succeeded Details
docs/core/preview3/windows-prerequisites.md ✅Succeeded Details
docs/core/tutorials/using-with-xplat-cli.md ✅Succeeded Details
docs/toc.md ✅Succeeded Details
samples/core/console-apps/FibonacciBetterMsBuild/Fibonacci.csproj ✅Succeeded Details
samples/core/console-apps/FibonacciBetterMsBuild/FibonacciGenerator.cs ✅Succeeded Details
samples/core/console-apps/FibonacciBetterMsBuild/Program.cs ✅Succeeded Details
samples/core/console-apps/HelloMsBuild/Hello.csproj ✅Succeeded Details
samples/core/console-apps/HelloMsBuild/Program.cs ✅Succeeded Details
samples/core/console-apps/HelloMsBuild/README.md ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/README.md ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/src/NewTypes/NewTypes.csproj ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/src/NewTypes/Pets/Cat.cs ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/src/NewTypes/Pets/Dog.cs ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/src/NewTypes/Pets/IPet.cs ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/src/NewTypes/Program.cs ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/test/NewTypesTests/NewTypesTests.csproj ✅Succeeded Details
samples/core/console-apps/NewTypesMsBuild/test/NewTypesTests/PetTests.cs ✅Succeeded Details

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants