Skip to content

Fix link to TestStartInfo in test-protocol.md #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

atifaziz
Copy link
Contributor

Link to TestStartInfo in test protocol documentation page was broken (404). It points to:

https://github.com/dotnet/cli/blob/rel/1.0.0/src/dotnet/commands/dotnet-test/TestStartInfo.cs

The correct link, however, appears to be:

https://github.com/dotnet/cli/blob/rel/1.0.0/src/Microsoft.DotNet.Tools.Test/TestStartInfo.cs

This PR fixes that.

@dnfclas
Copy link

dnfclas commented Sep 20, 2016

Hi @atifaziz, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@qinezh
Copy link
Contributor

qinezh commented Sep 20, 2016

Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:

Status: Succeeded.
Open Publishing Report.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atifaziz! It seems they have changed the location of some source files recently.

@mairaw mairaw merged commit 81e7604 into dotnet:master Sep 20, 2016
@atifaziz atifaziz deleted the patch-1 branch September 20, 2016 18:53
@atifaziz
Copy link
Contributor Author

It seems they have changed the location of some source files recently.

@mairaw Surprised though because the (old and new) links are off the 1.0.0 release tag so if moves happened after that then it shouldn't break anything, unless of course the tag was re-written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants