Skip to content

Conversation

@yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 18, 2023

Wait for network idle event before taking PDF screenshot. Try fix #9503

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Dec 18, 2023
@codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1613584) 71.37% compared to head (f4c491d) 71.35%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9542      +/-   ##
==========================================
- Coverage   71.37%   71.35%   -0.02%     
==========================================
  Files         558      558              
  Lines       24024    24032       +8     
  Branches     4173     4176       +3     
==========================================
+ Hits        17147    17148       +1     
- Misses       5780     5784       +4     
- Partials     1097     1100       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Dec 18, 2023
@yufeih yufeih reopened this Dec 18, 2023
@yufeih yufeih marked this pull request as ready for review December 18, 2023 09:16
@yufeih yufeih merged commit a58192e into main Dec 18, 2023
@yufeih yufeih deleted the pdfni branch December 18, 2023 09:16
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* fix: PDF wait for network idle

* test(snapshot): update snapshots d803445 for windows-latest

---------

Co-authored-by: yufeih <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PDF missing some svg images but present in html

2 participants