Skip to content

Conversation

@yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 9, 2023

Update TOC expansion logic to support these common static site URL rewrite rules:

  • Drop .html extension
  • Drop trailing /

This is a cheap fix to enable pretty URL with URL rewrite before #2865

Prior attempt #9036
Fixes #9231

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Nov 9, 2023
@codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@yufeih yufeih merged commit 2e626a3 into main Nov 10, 2023
@yufeih yufeih deleted the toc-node branch November 10, 2023 00:56
yufeih added a commit that referenced this pull request Nov 13, 2023
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Toc expansion does not work on url rewrite

2 participants