Skip to content

Conversation

@MihkelAuv
Copy link
Contributor

Docfx init command produces docfx.json with resources property name. However correct property name for resource files to include in the project output directory is resource (singular noun).

This PR fixes docfx.json produced by init command and corrects the property name in Config Reference page

@MihkelAuv
Copy link
Contributor Author

@dotnet-policy-service agree

@codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/docfx/Models/InitCommand.cs 82.17% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MihkelAuv !

@yufeih yufeih merged commit b7236c1 into dotnet:main Nov 8, 2023
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 10, 2023
yufeih pushed a commit that referenced this pull request Nov 13, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants