-
Couldn't load subscription status.
- Fork 876
Fix emoji font embedding in PDF generation #10678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: yufeih <511355+yufeih@users.noreply.github.com>
Co-authored-by: yufeih <511355+yufeih@users.noreply.github.com>
Co-authored-by: yufeih <511355+yufeih@users.noreply.github.com>
Co-authored-by: yufeih <511355+yufeih@users.noreply.github.com>
👍 emoji icon. docfx failed to embed relating font.|
@copilot revert all ur existing changes, install |
Co-authored-by: yufeih <511355+yufeih@users.noreply.github.com>
I've reverted all the code changes and updated the CI workflows to install
The changes are in commit 12fb85b. |
Problem
When using emoji characters like 👍 in markdown documents, DocFX failed to embed the necessary fonts in the generated PDF files. This resulted in "T3_font" appearing in Adobe Acrobat reader's property page, and these characters displaying incorrectly depending on the environment.
Solution
This PR modifies the PDF generation process to properly handle emoji characters by:
Automatically detecting and using emoji fonts if available on the system:
Adding an environment variable (
DOCFX_PDF_EMOJI_FONT) to specify a custom emoji font path:Adding diagnostic info to the PDF metadata to identify which emoji font was used
This change ensures that emoji characters are properly rendered in generated PDFs across different operating systems without requiring manual intervention.
Fixes #10484.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)crl3.digicert.comdotnet build(dns block)crl4.digicert.comdotnet build(dns block)dot.netwget REDACTED -O dotnet-install.sh(dns block)download.visualstudio.microsoft.comwget REDACTED -O dotnet-sdk.tar.gz(dns block)ocsp.digicert.comdotnet build(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)s.symcb.comdotnet build(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)s.symcd.comdotnet build(dns block)ts-crl.ws.symantec.comdotnet build(dns block)ts-ocsp.ws.symantec.comdotnet build(dns block)www.microsoft.comdotnet build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.