fix: Place .playwright
directory under bin directory
#10399
Merged
+3
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix issue #10398.
By temporary revert commit (#9363)
Background
When using
PLAYWRIGHT_NODEJS_PATH
environment variable.../../.playwright
fallback from bin directory is not used.And failed to find
.playwright\package\cli.js
file.To fix problems. it need to change
playwright-dotnet
side code(or install chromium browser directly by calling
.playwright/package/cli.js
)So I've temporary reverted #9363 code. And place
.playwright
folder under bin directory.By this changes.
.nupkg
size increased about1.8MB
.