Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Place .playwright directory under bin directory #10399

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 18, 2024

This PR intended to fix issue #10398.
By temporary revert commit (#9363)

Background
When using PLAYWRIGHT_NODEJS_PATH environment variable.
../../.playwright fallback from bin directory is not used.
And failed to find .playwright\package\cli.js file.

To fix problems. it need to change playwright-dotnet side code
(or install chromium browser directly by calling .playwright/package/cli.js)

So I've temporary reverted #9363 code. And place .playwright folder under bin directory.
By this changes. .nupkg size increased about 1.8MB.

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 19, 2024
@yufeih yufeih merged commit fc16c82 into dotnet:main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants