feat: Reformat YouTube videos to the embeded URL #10372
Open
+128
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
yufeih
added
the
new-feature
|
@hultqvist Could you also update the failed QuoteSectionNoteTest? |
|
Done, fixed so that rel=0 is only added on identified YouTube links, fixes one test. Now I also changed the "http" to "https" replacement and included a test for links containing the word "http" in other locations. |
Extract the YouTube video or list ID and generates the embed URL. Simplifies embedding YouTube videos by allowing one to copy paste the direct YouTube URL rather than extracting the embed URL from the <iframe> source. Also supports short youtu.be links. Add "rel=0" (unless explicitly specified) to only show related videos from the same channel. Add test for link with rel=1 Fix https enforcer to only replace at start of link. Add test for http replacement.
yufeih
approved these changes
Nov 18, 2024
yufeih
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the YouTube video or list ID and generates the embed URL.
Simplifies embedding YouTube videos by allowing one to copy paste the direct YouTube URL rather than extracting the embed URL from the <iframe> source.
Supports short youtu.be links.
Add "rel=0" (unless explicitly specified) to only show related videos from the same channel.