Skip to content

Commit dd69466

Browse files
authored
fix: toc grouping regression introduced by #10090 (#10700)
* fix: toc grouping regression introduced by #10090 * oversight
1 parent 15e1594 commit dd69466

File tree

2 files changed

+32
-13
lines changed

2 files changed

+32
-13
lines changed

templates/default/toc.html.primary.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,16 @@ function transformMemberPage(model) {
5959
"delegate": { key: "delegatesInSubtitle" },
6060
};
6161

62+
var groupBy = [
63+
"Constructor",
64+
"Field",
65+
"Property",
66+
"Method",
67+
"Event",
68+
"Operator",
69+
"Eii",
70+
];
71+
6272
groupChildren(model);
6373
transformItem(model, 1);
6474
return model;
@@ -71,7 +81,7 @@ function transformMemberPage(model) {
7181
var items = [];
7282
item.items.forEach(function (element) {
7383
groupChildren(element);
74-
if (element.type) {
84+
if (element.type && groupBy.includes(element.type)) {
7585
var type = element.isEii ? "eii" : element.type.toLowerCase();
7686
if (!grouped.hasOwnProperty(type)) {
7787
if (!groupNames.hasOwnProperty(type)) {

templates/default/toc.json.js

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,18 @@ exports.transform = function (model) {
1515
if (extension && extension.postTransform) {
1616
model = extension.postTransform(model);
1717
}
18-
18+
1919
for (var key in model) {
2020
if (key[0] === '_') {
2121
delete model[key]
2222
}
2323
}
24-
24+
2525
return {
2626
content: JSON.stringify(model)
2727
};
2828
}
29-
29+
3030
function transformMemberPage(model) {
3131
var groupNames = {
3232
"constructor": { key: "constructorsInSubtitle" },
@@ -43,11 +43,21 @@ exports.transform = function (model) {
4343
"namespace": { key: "namespacesInSubtitle" },
4444
"delegate": { key: "delegatesInSubtitle" },
4545
};
46-
46+
47+
var groupBy = [
48+
"Constructor",
49+
"Field",
50+
"Property",
51+
"Method",
52+
"Event",
53+
"Operator",
54+
"Eii",
55+
];
56+
4757
groupChildren(model);
4858
transformItem(model, 1);
4959
return model;
50-
60+
5161
function groupChildren(item) {
5262
if (!item || !item.items || item.items.length == 0) {
5363
return;
@@ -56,7 +66,7 @@ exports.transform = function (model) {
5666
var items = [];
5767
item.items.forEach(function (element) {
5868
groupChildren(element);
59-
if (element.type) {
69+
if (element.type && groupBy.includes(element.type)) {
6070
var type = element.isEii ? "eii" : element.type.toLowerCase();
6171
if (!grouped.hasOwnProperty(type)) {
6272
if (!groupNames.hasOwnProperty(type)) {
@@ -72,7 +82,7 @@ exports.transform = function (model) {
7282
items.push(element);
7383
}
7484
}, this);
75-
85+
7686
// With order defined in groupNames
7787
for (var key in groupNames) {
7888
if (groupNames.hasOwnProperty(key) && grouped.hasOwnProperty(key)) {
@@ -82,18 +92,18 @@ exports.transform = function (model) {
8292
})
8393
}
8494
}
85-
95+
8696
item.items = items;
8797
}
88-
98+
8999
function transformItem(item, level) {
90100
// set to null in case mustache looks up
91101
item.topicHref = item.topicHref || null;
92102
item.tocHref = item.tocHref || null;
93103
item.name = item.name || null;
94-
104+
95105
item.level = level;
96-
106+
97107
if (item.items && item.items.length > 0) {
98108
item.leaf = false;
99109
var length = item.items.length;
@@ -106,4 +116,3 @@ exports.transform = function (model) {
106116
}
107117
}
108118
}
109-

0 commit comments

Comments
 (0)