fix: Toc warnings when toc item with TopicUid but name is not specified (#9665)

filzrev · web-flow · commit 02173a7b8897 · 2024-02-10T13:58:38.000+08:00
fix: warnings for tocitem when topicuid  specified but name is not specified
diff --git a/src/Docfx.Build/ManifestProcessor.cs b/src/Docfx.Build/ManifestProcessor.cs
@@ -208,8 +208,13 @@ void UpdateTocNameCore(List<TocItemViewModel> items)
             {
                 if (string.IsNullOrEmpty(node.Name))
                 {
+                    // Try to get title from href
                     if (node.Href is not null && titles.TryGetValue(UriUtility.GetPath(node.Href), out var title))
                         node.Name = title;
+                    // If topicUid exists. Name is resolved by TocDocumentProcessor
+                    else if (node.TopicUid != null)
+                    {
+                    }
                     else
                         Logger.LogWarning(
                             $"TOC item ({node}) with empty name found. Missing a name?",

Original file line number	Diff line number	Diff line change
`@@ -208,8 +208,13 @@ void UpdateTocNameCore(List<TocItemViewModel> items)`
`208`	`208`	`{`
`209`	`209`	`if (string.IsNullOrEmpty(node.Name))`
`210`	`210`	`{`
	`211`	`+ // Try to get title from href`
`211`	`212`	`if (node.Href is not null && titles.TryGetValue(UriUtility.GetPath(node.Href), out var title))`
`212`	`213`	`node.Name = title;`
	`214`	`+ // If topicUid exists. Name is resolved by TocDocumentProcessor`
	`215`	`+ else if (node.TopicUid != null)`
	`216`	`+ {`
	`217`	`+ }`
`213`	`218`	`else`
`214`	`219`	`Logger.LogWarning(`
`215`	`220`	`$"TOC item ({node}) with empty name found. Missing a name?",`