This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update zlib-intel to v1.2.11.1_jtkv6.3 #36795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a repeat sequence longer than 258 would be encoded using longer distance values after the first match.
When we load new data into the window, we invalidate the next match, in case the match would improve. In this case, the hash has already been updated with this data, so when we look for a new match it will point it back at itself. As a result, a literal is generated even when a better match is available. This avoids that by catching this case and ensuring we're looking at the past.
stephentoub
approved these changes
Apr 11, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* inflate: handle windowBits == 16 * deflate_medium: add dist -1 to hash even for long matches This fixes an issue where a repeat sequence longer than 258 would be encoded using longer distance values after the first match. * deflate_medium: avoid emitting a suboptimal literal in the restart case When we load new data into the window, we invalidate the next match, in case the match would improve. In this case, the hash has already been updated with this data, so when we look for a new match it will point it back at itself. As a result, a literal is generated even when a better match is available. This avoids that by catching this case and ensuring we're looking at the past. Commit migrated from dotnet/corefx@6322a40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting @jtkukunas's fixes from https://github.com/jtkukunas/zlib/commits/master
https://github.com/jtkukunas/zlib/releases/tag/v1.2.11.1_jtkv6.3
Fix CompressionLevel.Optimal on sparse data. Fixes #34157
/cc @jtkukunas @vkvenkat @pensivebrian