Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix for missing symbol OnHijackTripThread #6656

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

jashook
Copy link

@jashook jashook commented Aug 8, 2016

PR #6522 changed from OnHijackScalarTripThread to OnHijackTripThread; however,
missed changing this definition for arm windows.

@jashook
Copy link
Author

jashook commented Aug 8, 2016

@jkotas ptal

/cc @dotnet/jit-contrib

@briansull
Copy link

briansull commented Aug 8, 2016

LGTM.

By the way there is still one remaining occurrence of OnHijackScalarTripThread in a comment...

D:\ProjectK\src\NDP\clr\src\vm>findstr /n /s OnHijackScalarTripThread  *.*
amd64\unixasmhelpers.S:177:// OnHijackScalarTripThread
arm\asmhelpers.asm:1708:        NESTED_ENTRY OnHijackScalarTripThread

@jkotas
Copy link
Member

jkotas commented Aug 8, 2016

Could you please also delete OnHijackGCTripThread from this file? It is unused after PR #6522.

PR dotnet#6522 changed from OnHijackScalarTripThread to OnHijackTripThread; however,
missed changing this definition for arm windows.
@jashook
Copy link
Author

jashook commented Aug 8, 2016

Comments addressed

@jkotas
Copy link
Member

jkotas commented Aug 8, 2016

👍

@briansull
Copy link

LGTM

@jashook
Copy link
Author

jashook commented Aug 8, 2016

Test failures are unrelated.

@jashook jashook merged commit e13714f into dotnet:master Aug 8, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Fix for missing symbol OnHijackTripThread

Commit migrated from dotnet/coreclr@e13714f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants