This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add OperationStatus-based UTF8 transcoding APIs #23219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
/cc @ahsonkhan, who expressed interest in these APIs. The PR here is the slow implementation. I'll get a PR out soon with a drop-in fast implementation once #22516 is also approved. |
Yes, this is awesome! Now, the only thing left is getting a fallback impl in the shared location ( |
ahsonkhan
approved these changes
Mar 13, 2019
tarekgh
reviewed
Mar 13, 2019
tarekgh
approved these changes
Mar 13, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Mar 13, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Mar 13, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Mar 13, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Mar 14, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 14, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 14, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the runtime implementation of https://github.com/dotnet/corefx/issues/34761.
Ref asm at https://github.com/dotnet/corefx/blob/98fbbcf5f131dd996ef4d3ae66201fa23cff39de/src/System.Runtime/ref/System.Runtime.cs#L7859.
Unit tests at https://github.com/dotnet/corefx/tree/dev/utf8string/src/System.Runtime/tests/System/Text/Unicode.