This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup DLL exports #22500
Merged
Cleanup DLL exports #22500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
force-pushed
the
dllexport
branch
3 times, most recently
from
667ad60 to
f45df99
Compare
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
Member
Author
|
Addressing #21924 (comment) |
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
am11
reviewed
Feb 10, 2019
| #ifndef PAL_STDCPP_COMPAT | ||
|
|
||
| PALIMPORT DLLEXPORT void __cdecl qsort(void *, size_t, size_t, int(__cdecl *)(const void *, const void *)); | ||
| PALIMPORT DLLEXPORT void * __cdecl bsearch(const void *, const void *, size_t, size_t, |
Member
There was a problem hiding this comment.
Could these be PALIMPORT PALAPI <retunType> bsearch/qsort/getenv/_putenv(.., as PALAPI is defined as DLLEXPORT __cdecl?
Member
Author
There was a problem hiding this comment.
The pattern used to export C-runtime APIs is PALIMPORT DLLEXPORT, so I kept this one for consistency.
C-runtime APIs were not PALAPIs originally when we had a thin (just forwarders) PAL layer for Windows as well. On Windows, the C-runtime APIs were cdecl, but PALAPIs were stdcall.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/coreclr@70cf6d4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.