[Arm64] Optimize JIT_WriteBarriers #12334
Conversation
|
@dotnet-bot test Tizen armel Cross Release Build please |
|
On second thought, I see the arm64 runs did not include test. @dotnet-bot help |
|
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@sdmaclea currently the windows arm64 testing seems broken I am looking into it. If I can get it online in a reasonable amount of time I will retry testing and merge. |
|
@jashook Thanks, I saw my PR were auto triggering Arm64 builds, but I didn't notice they were not triggering tests. I am in no hurry. |
|
@sdmaclea correct we had removed the tests from the debug build some time ago and removed checked testing (which tests) as a pr trigger. The reasons for doing this have since been obsoleted. @RussKeldorph and I spoke about adding the testing to auto trigger this morning. I have not yet got around to it. I will probably push that to later next week as a heads up. |
|
@jashook What is going on with the deleted comment from dotnet-bot? Twice today I saw that. This time I notice that the original dotnet-bot message is truncated and no longer shows all the options available to me. It also shows an incomplete list of auto triggers.... |
|
Ah I think some of us delete the comments out of habit sorry. |
|
No problem. I can see the original in my inbox. I was just wondering if we weren't supposed to trigger help |
|
You are good trigger help as much as needed. |
|
@dotnet-bot |
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@jashook Do we expect Windows_NT arm64 Checked to pass? I only see two runs in the history. 6/7 run passed. |
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@sdmaclea Could you please resolve the conflict? |
sdmaclea
force-pushed
the
PR-Optimize-Jit-WriteBarriers
branch
from
5cb8028 to
d153811
Compare
|
Rebased and resolved conflict |
|
@dotnet-bot test Tizen armel Cross Release Build |
|
Build timeout |
|
@dotnet-bot test Ubuntu arm64 Cross Debug Build |
|
@dotnet-bot test Tizen armel Cross Release Build |
|
"Ubuntu arm64 Cross Debug Build" error can be ignored per @jashook , can this be reviewed/merged |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
The Window AV looks like the same issue we saw when this merged last time and was reverted. Apparently, there is a bug in the Window Arm64 side of this patch. |
|
What is status of this PR? 1 month of no update ... |
|
@karelz This is next on my ToDo list. Windows arm64 build is failing. Plan to disable Windows portion of the patch and create a separate issue. |
|
OK, if it should take you more than 1-2 weeks to get to it, I would suggest to close the PR, while it is inactive. It can be easily reopened when you have time to work on it again. Thanks! |
Fixes #5833 Fixes #11374 Fixes #12197
sdmaclea
force-pushed
the
PR-Optimize-Jit-WriteBarriers
branch
from
d153811 to
2de13cf
Compare
|
@jkotas @dotnet/arm64-contrib I have disabled the optimization on Windows as it was causing a contract Violation. I opened #13592 to enable. The disable is a separate patch hopefully to make it easy to reenable, debug ... |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
@jashook Looks like all recent arm64 PRs are failing. |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Build and Test |
1 similar comment
|
@dotnet-bot test Windows_NT arm64 Cross Checked Build and Test |
|
@dotnet-bot test Windows_NT Arm64 Checked |
|
Thank you! |
|
:mips-interest |
Fixes #5833
Fixes #11374
Fixes #12197