Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix link for up-for-grabs issues #10488

Merged
merged 3 commits into from
Mar 28, 2017
Merged

Fix link for up-for-grabs issues #10488

merged 3 commits into from
Mar 28, 2017

Conversation

borsna
Copy link

@borsna borsna commented Mar 26, 2017

No description provided.

@jkotas
Copy link
Member

jkotas commented Mar 26, 2017

@karelz Looks like this was broken by issue label renaming. It should have been renamed the other way: CoreCLR was using the github standard up-for-grabs, e.g. from http://up-for-grabs.net/#/: we suggest the tag up-for-grabs...

@karelz
Copy link
Member

karelz commented Mar 26, 2017

Yeah, I wasn't aware of that github standard when I was aligning our repos and I blindly used what CoreFX had, trusting it is "right". I am fine changing it to up-for-grabs on our repos (incl. documentation updates and up-for-grabs.net update) - I'll be happy to make the changes myself.
Does it sound like a reasonable change to you?

@jkotas
Copy link
Member

jkotas commented Mar 26, 2017

Does it sound like a reasonable change to you?

Yes 👍

@karelz
Copy link
Member

karelz commented Mar 26, 2017

@karelz
Copy link
Member

karelz commented Mar 26, 2017

I will run it by area owners in both repos. Just want to make sure no one is affected too much.

@borsna thanks a lot for you contribution! We are likely going to decide to swing the other way, sorry for that.
Are you interested in helping make the change in https://github.com/dotnet/corefx/issues/17533? (after we have agreement among key repo owners)

@karelz karelz added area-Meta blocked Issue/PR is blocked on something - see comments labels Mar 26, 2017
@borsna
Copy link
Author

borsna commented Mar 26, 2017

@karelz just wanted to make a quick fix suggestion, the change for up-for-grabs sound better (was not aware of up-for-grabs.net)👍
Can do a pull request fro dotnet/corefx when the renaming of the labels is done.

@karelz
Copy link
Member

karelz commented Mar 26, 2017

@borsna thanks!
BTW: I plan to do label rename and merging of PRs at the same-ish moment. As soon as we have team-wide agreement ;-).

@dnfclas
Copy link

dnfclas commented Mar 27, 2017

@borsna, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@karelz
Copy link
Member

karelz commented Mar 27, 2017

@gkhanna79 @jkotas I see 3 failures on doc change, is that expected failure rate?

baseservices_threading.waithandle_waitany_waitanyex2_waitanyex2._waithandle_waitany_waitanyex2_waitanyex2_cmd (from baseservices.threading.XUnitWrapper)

MESSAGE:
\n\nReturn code: 1\nRaw output file: D:\\j\\workspace\\x64_release_w---0575cb46\\bin\\tests\\Windows_NT.x64.Release\\Reports\\baseservices.threading\\waithandle\\waitany\\waitanyex2\\waitanyex2.output.txt\nRaw output:\nBEGIN EXECUTION\r\n \"D:\\j\\workspace\\x64_release_w---0575cb46\\tests\\..\\bin\\tests\\Windows_NT.x64.Release\\Tests\\Core_Root\\corerun.exe\" waitanyex2.exe \r\nName created: fb0ff97a-57c0-499b-b3a9-6cf60dea23b0\r\nTesting Mutex and non-Mutex, and signaling the other element\r\nAcquire the Mutex\r\nHolding the Mutex\r\nWaiting...\r\nWaitAny did not throw AbandonedMutexException\r\nTest Failed\r\nExpected: 100\r\nActual: -1\r\nEND EXECUTION - FAILED\r\nFAILED\r\nTest Harness Exitcode is : 1\r\n\nTo run the test:\n> set CORE_ROOT=D:\\j\\workspace\\x64_release_w---0575cb46\\bin\\tests\\Windows_NT.x64.Release\\Tests\\Core_Root\n> D:\\j\\workspace\\x64_release_w---0575cb46\\bin\\tests\\Windows_NT.x64.Release\\baseservices\\threading\\waithandle\\waitany\\waitanyex2\\waitanyex2.cmd\n\r\nExpected: True\r\nActual: False
+++++++++++++++++++
STACK TRACE:
at baseservices_threading._waithandle_waitany_waitanyex2_waitanyex2_._waithandle_waitany_waitanyex2_waitanyex2_cmd() in D:\j\workspace\x64_release_w---0575cb46\bin\tests\Windows_NT.x64.Release\TestWrappers\baseservices.threading\baseservices.threading.XUnitWrapper.cs:line 28667

@jkotas
Copy link
Member

jkotas commented Mar 28, 2017

Looks like this run got really unlucky:

#1 is infrastructure issue
#2 is known #10022
#3 is a failure not seen before. Opened #10514 .

@jkotas
Copy link
Member

jkotas commented Mar 28, 2017

@dotnet-bot test OSX10.12 x64 Checked Build and Test please
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please
@dotnet-bot test Windows_NT x86 Checked Build and Test please

@danmoseley
Copy link
Member

@karelz you can bypass or ignore CI for changes under documentation/...

@karelz
Copy link
Member

karelz commented Mar 28, 2017

@danmosemsft I know - it was just surprising number of failures ...

@karelz karelz merged commit 440a287 into dotnet:master Mar 28, 2017
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta blocked Issue/PR is blocked on something - see comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants