-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
@karelz Looks like this was broken by issue label renaming. It should have been renamed the other way: CoreCLR was using the github standard |
Yeah, I wasn't aware of that github standard when I was aligning our repos and I blindly used what CoreFX had, trusting it is "right". I am fine changing it to up-for-grabs on our repos (incl. documentation updates and up-for-grabs.net update) - I'll be happy to make the changes myself. |
Yes 👍 |
I will run it by area owners in both repos. Just want to make sure no one is affected too much. @borsna thanks a lot for you contribution! We are likely going to decide to swing the other way, sorry for that. |
@karelz just wanted to make a quick fix suggestion, the change for |
@borsna thanks! |
Merge when changes to the issue label is done
@borsna, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
@gkhanna79 @jkotas I see 3 failures on doc change, is that expected failure rate?
baseservices_threading.waithandle_waitany_waitanyex2_waitanyex2._waithandle_waitany_waitanyex2_waitanyex2_cmd (from baseservices.threading.XUnitWrapper)
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test please |
@karelz you can bypass or ignore CI for changes under documentation/... |
@danmosemsft I know - it was just surprising number of failures ... |
No description provided.