This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add JIT Coding Conventions document in markdown format #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceForstall
added
the
documentation
|
LGTM |
|
Bugs me a little bit that the TOC starts numbering at 4, but I sort of understand why that happened. |
|
I am wondering why the "Contents" section starts from # 4. |
|
Regarding TOC starting at section 4: that's a remnant of the conversion from Word. Unfortunately, markdown format is, uh, simple, so renumbering everything would be a huge pain. Maybe there's a tool that can do this easily (that I don't know about). Anyway, IMO, not a big deal. If we ever want to add sections and need to renumber, then it will become annoying and problematic. |
BruceForstall
force-pushed
the
JitCodingConventions
branch
from
2035189 to
0d8da10
Compare
|
I responded to feedback and squashed the commits. |
CarolEidt
added a commit
that referenced
this pull request
May 19, 2015
Add JIT Coding Conventions document in markdown format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review that I've done the markdown formatting "correctly", not the content of the document.
/cc @richlander @briansull @CarolEidt @sivarv @schellap @cmckinsey