Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 7c84cde

Browse files
committed
Turn off CoreFX test legs in CI.
Now that the branch is on servicing, and the churn is low, exclude these as they break far more often than they detect issues. These already run in CoreFX CI on release bits. In case we want to bring them back for checked testing, we need to fix CoreFX.depproj. It has a package - Microsoft.Private.CoreFx.OOB - that's supposed to bring in all deps that are out of box. These are currently not getting restored and this ends up causing File not found issues in the binder when compiling tests, making test exclusions impossible. Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit.
1 parent c7c87ce commit 7c84cde

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

eng/pipelines/pr.yml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,21 @@ jobs:
9393

9494
#
9595
# CoreFX test runs against CoreCLR
96-
#
97-
- template: /eng/platform-matrix.yml
98-
parameters:
99-
jobTemplate: test-job.yml
100-
buildConfig: checked
101-
platforms:
102-
- Linux_x64
103-
- Windows_NT_x64
104-
helixQueueGroup: pr
105-
jobParameters:
96+
# Now that the branch is on servicing, and the churn is low, exclude these as they
97+
# break far more often than they detect issues. These already run in CoreFX CI on release bits.
98+
# In case we want to bring them back for checked testing, we need to fix CoreFX.depproj.
99+
# It has a package - Microsoft.Private.CoreFx.OOB - that's supposed to bring in all deps
100+
# that are out of box. These are currently not getting restored and this ends up causing
101+
# File not found issues in the binder when compiling tests, making test exclusions impossible.
102+
# - template: /eng/platform-matrix.yml
103+
# parameters:
104+
# jobTemplate: test-job.yml
105+
# buildConfig: checked
106+
# platforms:
107+
# - Linux_x64
108+
# - Windows_NT_x64
109+
# helixQueueGroup: pr
110+
# jobParameters:
106111
testGroup: innerloop
107112
corefxTests: true
108113
displayNameArgs: CoreFX

0 commit comments

Comments
 (0)