This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move signing dir under eng/. Remove usages of ProjectDir. #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Oct 21, 2019
|
Can you kick one off? |
|
Looks like the internal build failed. |
|
The failure is the Microsoft.NET.HostModel test project being unable to access Looking back at failed official builds, I see it happening at least once before. I need to have the tests wait for signing to complete--this bug has been there for a while, apparently, it just hasn't happened enough for me to see it. Filed https://github.com/dotnet/core-setup/issues/8626. Running a retry on that validation build to try to get past that flakiness and get on to the rest of the infra. |
|
Retry worked. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on feedback to #8593