Skip to content

Fixed null reference exception in Token operator overload #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fixed null reference exception in Token operator overload #1842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/System.CommandLine/Parsing/Token.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ internal Token(string? value, TokenType type, Symbol? symbol, int position)
/// <param name="left">The first <see cref="Token"/>.</param>
/// <param name="right">The second <see cref="Token"/>.</param>
/// <returns><see langword="true" /> if the objects are equal.</returns>
public static bool operator ==(Token left, Token right) => left.Equals(right);
public static bool operator ==(Token? left, Token? right) => left is null ? right is null : left.Equals(right);

/// <summary>
/// Checks if two specified <see cref="Token"/> instances have different values.
/// </summary>
/// <param name="left">The first <see cref="Token"/>.</param>
/// <param name="right">The second <see cref="Token"/>.</param>
/// <returns><see langword="true" /> if the objects are not equal.</returns>
public static bool operator !=(Token left, Token right) => !left.Equals(right);
public static bool operator !=(Token? left, Token? right) => left is null ? right is not null : !left.Equals(right);

}
}