Windows Setup Fix for Non-Administrator Users #90
Conversation
I've modified the setup function to check for the global flag. The script will no longer attempt to install KVM globally and locally. The -g flag can allow it to be installed system-wide.
Modified the kvminstall script for my forked repository...
Note to self, the GitHub client is horrible as single-file commits...
|
@meyerrj thanks for the PR. Have you filed out a CLA (https://github.com/aspnet/Home/blob/master/CONTRIBUTING.md#contributing-code-and-content)? After doing that, kvm changes should be made in https://github.com/aspnet/KRuntime/tree/dev/setup |
|
@davidfowl Thanks for pointing that out. Looks like I'll have to check with my employer tomorrow, hopefully they won't have a problem with it. :) |
|
@meyerrj Did you have any issues with the CLA? |
|
@glennc It's been sent to my employer's legal department... I've been told it might take a few weeks before I hear back. I'm hoping they won't have an issue with it. |
|
@meyerrj Great, let us know how it goes. |
|
I just wanted to follow up with my paperwork status. The paperwork is still working its way through my employer (state university), but it is progressing... I'm keeping my fingers crossed. :) I also noticed that there are now merge conflicts. Should I cancel this pull request and revisit submitting patches once the paperwork is officially ironed out? |
|
@meyerrj You can leave this one or cancel it if you wish. Once the CLA is done then you have to get it into a state that we can merge again. It's up to you if you want to cancel and resubmit it later or just re-base this one. |
…d on resourcetype's name instead of full name
I've resolved an issue where non-administrator users could not use the scripts to setup KVM.
I encountered an issue where Windows cannot access the script files if they're not in an administrator owned folder.
I've modified the script so that it only install to the user's home folder by default. If a user wants to install it globally, they can use the -g or -global switch to install it there, and only there.