Throw if CORS policy is configured to allow credentials and any origin #7751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-mvc
pranavkm
force-pushed
the
prkrishn/3106
branch
from
1d05875 to
a7642e2
Compare
mkArtakMSFT
approved these changes
Feb 20, 2019
rynowak
reviewed
Feb 21, 2019
| @@ -224,6 +224,11 @@ public CorsPolicyBuilder SetIsOriginAllowedToAllowWildcardSubdomains() | |||
| /// <returns>The constructed <see cref="CorsPolicy"/>.</returns> | |||
| public CorsPolicy Build() | |||
| { | |||
| if (_policy.AllowAnyOrigin && _policy.SupportsCredentials) | |||
There was a problem hiding this comment.
You have to call Build to get to the the result of Combine.
rynowak
approved these changes
Feb 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3106
Changes per #3106 (comment)